4.2.0 Beta4 backend issue for Sayontan

[Colin]

Sayontan, this is what I meant about the backend looking odd.

Suffusion.png (24.03 KiB) Viewed 1065 times

[MarkvanJaarsveld]

Sayontan/ Colin

This behaviour has been present since the release of Suffusion 4.0.0,...
http://suffusion4b4.gandiawebdesign.com/?p=2800

[Colin]

Mark

For me it hasn't this is the first time that I have seen it on any of my sites. See below which is a current 4.0.6 installation.

Suffusion1.png (18.26 KiB) Viewed 1057 times

[sayontan]

Can you tell me how to replicate it? E.g. When I go to Mark's site with 4.2.0 B3, things look fine in the back-end.

[Colin]

Sent you a PM with login details

[sayontan]

Colin,
This is a Jigoshop bug. Basically they have got their CSS interfering with other admin screens. E.g. when I visit Suffusion's admin screen, I see this included:

Code: Select all

<link rel='stylesheet' id='jigoshop_admin_styles-css'  href='http://lop.orba-design.com/wp-content/plugins/jigoshop/assets/css/admin.css?ver=3.3.2' type='text/css' media='all' />
<link rel='stylesheet' id='jquery-ui-jigoshop-styles-css'  href='http://lop.orba-design.com/wp-content/plugins/jigoshop/assets/css/jquery-ui-1.8.16.jigoshop.css?ver=3.3.2' type='text/css' media='all' />


This is wrong, because Jigoshop should not be including these scripts in screens that it doesn't control. If you disable Jigoshop you will see that things will be fine.

[Colin]

Great. Glad it isn't a problem for you.

I will contact Jigoshop and let them know.

[sayontan]

I have already posted something: http://wordpress.org/support/topic/jigo ... ?replies=1. Don't know if Jigoshop handles support this way, though.

[Colin]

Sayontan, they reckon it can't be fixed your way and the solution they have come up with looks even worse.

See http://forum.jigoshop.com/discussions/p ... in-screens

[sayontan]

admin.css holds our icon placements, so if we removed admin.css from every other menu except Jigoshop, you'd see something like this
http://i.imgur.com/ZAeqW.png

This is of course, totally wrong. Bear in mind that there are literally thousands of plugins that get this right and Jigoshop is not one of them. If the main concern is about getting the right icon in the menu on the left side, that is very easily fixed. This is what they have in the jigoshop-admin.php file :

Code: Select all

    add_menu_page(__('Jigoshop'), __('Jigoshop'), 'manage_options', 'jigoshop' , 'jigoshop_dashboard', jigoshop::assets_url() . '/assets/images/icons/menu_icons.png', 55);

That icon is a sprite, and they are using admin.css to control the position of the sprite. They have two options:

1. Change it from a sprite to a single icon. They won't get their fancy greyscale vs. colour icon, but WP natively applies an opacity to the icon when the menu item is not active.
2. Or they could move the styles for this icon alone to the HTML directly by means of the 'admin_head' hook (they even have a function called jigoshop_admin_head for this):
   

   Code: Select all

   function jigoshop_admin_head() {
   ?>
   <style type="text/css">

      <?php if ( isset($_GET['taxonomy']) && $_GET['taxonomy']=='product_cat' ) : ?>
         .icon32-posts-product { background-position: -243px -5px !important; }
      <?php elseif ( isset($_GET['taxonomy']) && $_GET['taxonomy']=='product_tag' ) : ?>
         .icon32-posts-product { background-position: -301px -5px !important; }
      <?php endif; ?>

      /* The above piece is already there. The stuff below needs to be added .... */
      #toplevel_page_jigoshop .wp-menu-image {
         background: url(<?php echo jigoshop::assets_url() . '/assets/images/icons/menu_icons.png'; ?>) no-repeat top left !important;
      }
      #toplevel_page_jigoshop:hover .wp-menu-image, #toplevel_page_jigoshop.wp-has-current-submenu .wp-menu-image {
         background-position: -28px 0 !important; /* Adjust as per sprite's dimensions. */
      }
   </style>
   <?php
}


To be frank, I am surprised at their response. This isn't for me to fix - it is their bug. I provided them with the means to include the script correctly, and the least they could have done was gone the extra mile and figured out this piece. Including a whole CSS file just because they want to style one icon isn't really cool.