Bug: Wrong URL in custom-styles.css

[raubvogel]

Hi Sayontan,

if I choose "Back-end -> Site Optimization -> Auto-generate the CSS and link it as a file (Low load on server, elegant page source code)", a file called "custom-styles.css" will be generated containing css for the icon set, i. e., something like background-image: url(https://blogsystem.nobodyknows.de/tc-st ... nset-2.png); The url should start with "http" not with "https". I think https is chosen because I’m logged in over https in the admin area. I have no valid certificate for https. Therefore FireFox, IE and Chrome will not load the icons. Could You please fix this?

Suffusion version: 4.2.0

Best regards
Ronny

[sayontan]

The URL is picked based on the Site URL you specify in the back-end of WordPress (not Suffusion). Suffusion has no control over the seurity protocol that you have set up.

[raubvogel]

Hi Sayontan,

I'm using a Wordpress Network (multisite). Only the admin environmet is forced to be https. The public pages are all http. If I use the upload function (e.g. header image) in your configuration, a normal http-URL is generated, not a https one. I'm confused I will have a look at Your source code tomorrow …

EDIT:
- Looked at \wordpress\wp-content\themes\suffusion\suffusion-css-generator.php:943
- … .icon {
background-image: url(".get_template_directory_uri()."/images/$suf_iconset.png);
}
- I think get_template_directory_uri() cannot be correct here (returns https in admin environment). Any ideas?
- Hoever, get_template_directory_uri() is correct if the css is not generated (i.e., generated on the fly).

Greeting from Germany
Ronny

[raubvogel]

Hm, I have no idea what function has to replace get_template_directory_uri(). Fact: get_template_directory_uri() should not be used if style sheets or other code is generated from admin environment (-> https issue). This could be a general issue is Suffusion Theme …

[sayontan]

This could be a general issue is Suffusion Theme …

Why? It is not a Suffusion function, hence it is not a Suffusion issue. If get_template_directory_uri() returns different results from your backend vs. the frontend, it is a WP issue, not a Suffusion issue. WP's recommended method to determine your theme folder is get_template_directory_uri() - the other replacements for it are not accepted by the theme reviewers.

[raubvogel]

That not quite right, I think. You generate an url in the backend for the frontend. In the backend get_template_directory_uri() returns https://your-site/theme/… and in the frontend it returns http://your-site/theme/… It seems there is no appropriate function in wordpress for this case – I could not find one.