suffusion_set_more_link filter breaks validation

[metal450]

The filter suffusion_set_more_link wraps the Read More text in a div. This works fine if <!--more--> is on a line by itself, but if it's in the middle of a paragraph, the result is that wpautop "forgets" to close the <p> tag for that paragraph. i.e. given the content:

This is a paragraph. Wanna read the rest? <!--more--> Well here it is!

Wordpress will generate:

<p>This is a paragraph. Wanna read the rest?
<div class='more-link fix'> <a href="..." class="more-link">Continue reading &raquo;</a></div>

Thus the <p> tag isn't closed, and validation breaks.

[sayontan]

That is not within the theme developer's scope. Technically there are several things that a blog poster could break using invalid tags - you can't expect the theme developer to fix all of them.

[metal450]

Huh? But it's the theme that's wrapping the "read more" text in a div; if that suffusion filter is removed, it validates just fine. From what I've seen there's nothing in Wordpress that stipulates "<!--more-->" must be on its own line and not within a paragraph: http://codex.wordpress.org/Customizing_the_Read_More

Furthermore, putting <!--more--> within a paragraph validates just fine on the default/classic themes. It's the addition of the <div> by suffusion_set_more_link that makes it not validate...

[metal450]

Also, changing <div> to <span> in that function makes it valid (regardless of where the author places their <!--more-->)

[metal450]

Thanx for fixing it