Loading issue & CodeStyling Localization

Reports about issues that you encounter in Suffusion. This forum is closed with effect from February 2019. Please post future requests on https://github.com/sayontan/suffusion.
Forum rules
This forum is being officially closed with effect from 3rd February 2019. Future support requests can be posted on the GitHub page at https://github.com/sayontan/suffusion/issues.
Locked
MarcoS
Posts: 1
Joined: 19 Jun 2014, 06:54

Loading issue & CodeStyling Localization

Post by MarcoS » 19 Jun 2014, 07:08

As an active member, I am supporting the WordPress community by translating several plugins.
For tanslation of some plugings, one of my favorite plugins is CodeStyling Localization (of course poEdit is used as well)
However, the combination with the Suffusion theme with this Codestyling plugin is causing problems with the loccalization and functionality of core WordPress
I guess it is a minor thing, but of course it is our goal to achieve the best.
On the informationpage of CodeStyling Localization (Tools > Localization) the following can be seen:
(Scroll down to Suffusion theme)
Loading Issue: Author is using load_textdomain instead of load_theme_textdomain or load_child_theme_textdomain function. This may break behavior of WordPress, because some filters and actions won't be executed anymore. Please contact the Author about that.

drake
Posts: 6223
Joined: 26 Jul 2011, 07:56
Location: Constanta, Romania
Contact:

Re: Loading issue & CodeStyling Localization

Post by drake » 19 Jun 2014, 11:24

OK, please, can you give me the link from CODEX or anywhere else load_textdomain is deprecated or forbidden to be used in themes or plugins?... I found just this page in CODEX: http://codex.wordpress.org/Function_Ref ... textdomain ... No mention to any problem... no recommendation to use other function... no deprecation...

The plugin of Heiko Rabe is indeed a very powerful tool for translators... and I've used it often with great results with Suffusion and with many plugins despite of it's many warnings related to almost anything... I wonder why a plugin related to translations is more trusted than a Security Plugin (as CodeStyling wipe the floor with Wordfence Security). In the same way... the recommendation of a function or other is at least misplaced if is not specified in Codex or in any other official recommendation.

And... unlike the plugins, where a function can be changed overnight directly by their authors, for themes is not so simple... Changing a single line in a theme means a new version... a new version need to be approved by WPRT... for getting the approval of a new version of Suffusion, Sayontan need to take out of theme at least the SEO options... Now say... what is more important? A warning from a plugin used by few (plugin which still works fine despite this warning), or breaking a feature used by thousands of users?

Anyway, for latest translations of Suffusion or Photonic, or for making your own translations, without a plugin, can visit: http://pool.aquoid.com/translations/projects

Locked